Bug 80734 - [V8] Fix a fixme in v8 bindings
Summary: [V8] Fix a fixme in v8 bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-09 14:58 PST by Erik Arvidsson
Modified: 2012-03-09 21:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.52 KB, patch)
2012-03-09 15:01 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch for landing (1.36 KB, patch)
2012-03-09 16:20 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch for landing (1.33 KB, patch)
2012-03-09 16:23 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch (2.28 KB, patch)
2012-03-09 16:25 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-03-09 14:58:43 PST 
[V8] Fix a fixme in v8 bindings and inline fast case for toInt32 and toUInt32
Comment 1 Erik Arvidsson 2012-03-09 15:01:20 PST 
Created attachment 131119 [details]
Patch
Comment 2 Erik Arvidsson 2012-03-09 15:02:35 PST 
toUInt32 and toInt32 are not used in normal DOM code paths so it is not very hot. I see WebGL related methods using it so I expect that this might have some benefit there.
Comment 3 Kentaro Hara 2012-03-09 15:11:10 PST 
Comment on attachment 131119 [details]
Patch

This change looks good in that it removes FIXME. But basically I wanted to see some performance tests (e.g. "XXX becomes YYY% faster") if you intend to make some performance optimization (i.e. inlining). We are likely to make wasteful "optimization".
Comment 4 Erik Arvidsson 2012-03-09 16:04:20 PST 
I made a quick test with ArrayBuffer and the inlining had no effect.

Uploading new patch in a second
Comment 5 Erik Arvidsson 2012-03-09 16:20:29 PST 
Created attachment 131129 [details]
Patch for landing
Comment 6 Erik Arvidsson 2012-03-09 16:23:33 PST 
Created attachment 131131 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-03-09 16:25:16 PST 
Attachment 131131 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/bindings/v8/V8Binding.cpp']" exit_code: 1
Source/WebCore/bindings/v8/V8Binding.cpp:246:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Erik Arvidsson 2012-03-09 16:25:55 PST 
Created attachment 131133 [details]
Patch
Comment 9 WebKit Review Bot 2012-03-09 21:05:10 PST 
Comment on attachment 131133 [details]
Patch

Clearing flags on attachment: 131133

Committed r110369: <http://trac.webkit.org/changeset/110369>
Comment 10 WebKit Review Bot 2012-03-09 21:05:16 PST 
All reviewed patches have been landed.  Closing bug.