Convert the fast/regions/webkit-flow* pixel tests to reftests
Created attachment 200003 [details] Patch
Created attachment 200005 [details] Patch
Comment on attachment 200005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200005&action=review Thanks, looks good! I have a couple of hints below. The comments apply for both html files. > LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:5 > + text-align: justify; nit: you have different indentation styles in the style elements. > LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:87 > + margin-top: -22px; <p> tags have margin-top/bottom set using "em" units. I think you could avoid using <p> tags or set the margins to 0 to avoid having to compensate for it in the parent box. Setting the margin this way makes the ref-test fragile when changing the default font-size.
Created attachment 200097 [details] Patch Made recommended changes
Remaining tests will be tracked in https://bugs.webkit.org/show_bug.cgi?id=115422
Comment on attachment 200097 [details] Patch Looks better. R=me You need to set the CQ? flag if you want the reviewer to set the CQ+ flag.
Comment on attachment 200097 [details] Patch Clearing flags on attachment: 200097 Committed r149374: <http://trac.webkit.org/changeset/149374>
All reviewed patches have been landed. Closing bug.