Bug 80701 - getCueAsHTML() should return different fragments
Summary: getCueAsHTML() should return different fragments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 79746
  Show dependency treegraph
 
Reported: 2012-03-09 06:40 PST by Victor Carbune
Modified: 2012-03-09 11:16 PST (History)
2 users (show)

See Also:


Attachments
Fixed method and added test (10.88 KB, patch)
2012-03-09 06:57 PST, Victor Carbune
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Carbune 2012-03-09 06:40:09 PST
Currently, the document fragment returned by getCueAsHTML() can't be appended multiple times to the DOM.
Comment 1 Victor Carbune 2012-03-09 06:57:41 PST
Created attachment 131036 [details]
Fixed method and added test
Comment 2 Eric Carlson 2012-03-09 10:25:21 PST
Comment on attachment 131036 [details]
Fixed method and added test

View in context: https://bugs.webkit.org/attachment.cgi?id=131036&action=review

Nice fix and terrific test - thanks!

> Source/WebCore/html/track/TextTrackCue.cpp:362
> +    RefPtr<DocumentFragment> clonedFragment;
> +    Document* document;

Nit: There is no need to declare these here and initialize them further down in the function. No need to have this block landing the fix, but lets fix it the next time we modify this file.
Comment 3 WebKit Review Bot 2012-03-09 11:16:28 PST
Comment on attachment 131036 [details]
Fixed method and added test

Clearing flags on attachment: 131036

Committed r110308: <http://trac.webkit.org/changeset/110308>
Comment 4 WebKit Review Bot 2012-03-09 11:16:32 PST
All reviewed patches have been landed.  Closing bug.