Web Notification doesn't work on master_35 after rebase. The upstreaming notification is now connected in different way. We need to adapt the new way of connecting the Notifications to the WebCore.
New way: WebCore::provideNotificaiton() , defined in NotificaionController.h/cpp
old way: ChromeClient::notificaionPresenter(), which is removed .
Internal PR: 142886
Created attachment 131022 [details]
With this patch, we did:
1. Namespace of NotificationPresenterImpl moved from WebKit to WebCore. All code in WebCoreSupport should be in the namespace of WebCore.
2. Remove the un-needed ChromeClientBlackBerry::notificationPresenter
3. Connect the NotificationPresenter to WebCore using WebCore::provideNotification(Page*, NotificationPresenter*).
Comment on attachment 131022 [details]
Clearing flags on attachment: 131022
Committed r110290: <http://trac.webkit.org/changeset/110290>
All reviewed patches have been landed. Closing bug.
This should not have landed.
We are not landing any m35 only patches until it is deployed.
What should we do reopening it? should we revert the patch ?
Well, we can close it. I do not think it can cause backport problems. Rob also landed a few patches in the same situation (m35) , but we've agreed to wait a bit, and some patches are on hold.
Lets leave this one in : ) why not?