Bug 80690 - [BlackBerry] Web Notification not working after rebase
Summary: [BlackBerry] Web Notification not working after rebase
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Nobody
Depends on:
Reported: 2012-03-09 02:40 PST by Charles Wei
Modified: 2012-03-09 20:42 PST (History)
4 users (show)

See Also:

Patch (6.15 KB, patch)
2012-03-09 03:09 PST, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-03-09 02:40:57 PST
Web Notification doesn't work on master_35 after rebase.  The upstreaming notification is now connected in different way. We need to adapt the new way of connecting the Notifications to the WebCore.

New way:   WebCore::provideNotificaiton() , defined in NotificaionController.h/cpp

old way:    ChromeClient::notificaionPresenter(),  which is removed .
Comment 1 Charles Wei 2012-03-09 02:42:38 PST
Internal PR: 142886
Comment 2 Charles Wei 2012-03-09 03:09:35 PST
Created attachment 131022 [details]

With this patch, we did:

1. Namespace of NotificationPresenterImpl moved from WebKit to WebCore. All code in WebCoreSupport should be in the namespace of WebCore.
2. Remove the un-needed ChromeClientBlackBerry::notificationPresenter
3. Connect the NotificationPresenter to WebCore using WebCore::provideNotification(Page*, NotificationPresenter*).
Comment 3 WebKit Review Bot 2012-03-09 05:11:43 PST
Comment on attachment 131022 [details]

Clearing flags on attachment: 131022

Committed r110290: <http://trac.webkit.org/changeset/110290>
Comment 4 WebKit Review Bot 2012-03-09 05:11:48 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Antonio Gomes 2012-03-09 05:21:01 PST
This should not have landed.

We are not landing any m35 only patches until it is deployed.
Comment 6 Antonio Gomes 2012-03-09 05:22:57 PST
Comment 7 Charles Wei 2012-03-09 20:30:56 PST
What should we do reopening it? should we revert the patch ?
Comment 8 Antonio Gomes 2012-03-09 20:42:44 PST
Well, we can close it. I do not think it can cause backport problems. Rob also landed a few patches in the same situation (m35) , but we've agreed to wait a bit, and some patches are on hold.

Lets leave this one in : ) why not?