Bug 80689 - [Qt] fast/viewport/viewport-133.html fails
Summary: [Qt] fast/viewport/viewport-133.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-03-09 02:28 PST by Nandor Huszka
Modified: 2012-06-08 07:11 PDT (History)
3 users (show)

See Also:


Attachments
patch (1.32 KB, patch)
2012-06-06 11:09 PDT, qi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nandor Huszka 2012-03-09 02:28:12 PST
Because of r110197 this test fails.
Comment 1 Csaba Osztrogonác 2012-03-09 02:36:39 PST
I don't think if we need one more bug report for it.

*** This bug has been marked as a duplicate of bug 80292 ***
Comment 2 Konrad Piascik 2012-03-09 11:59:15 PST
I don't believe that this is a duplicate of bug 80292 but is a bug in its own right.  I don't have privileges to edit bugs otherwise I'd re-open it.

The other ports EFL and GTK don't make the following call:
d->page->setDeviceScaleFactor(conf.devicePixelRatio);

http://trac.webkit.org/browser/trunk/Source/WebKit/qt/Api/qwebpage.cpp?rev=93303#L2571

The above call should be updating window.devicePixelRatio.  Since this isn't happening I think that there may be an issue with Qt. which fast/viewport/viewport-133.html uncovered.
Comment 3 Csaba Osztrogonác 2012-03-10 01:18:18 PST
.
Comment 4 qi 2012-06-06 11:09:32 PDT
Created attachment 146065 [details]
patch

This test case was removed (https://bugs.webkit.org/show_bug.cgi?id=88047). It is not valid case now. Remove it form skip list.
Comment 5 WebKit Review Bot 2012-06-08 07:11:49 PDT
Comment on attachment 146065 [details]
patch

Clearing flags on attachment: 146065

Committed r119827: <http://trac.webkit.org/changeset/119827>
Comment 6 WebKit Review Bot 2012-06-08 07:11:54 PDT
All reviewed patches have been landed.  Closing bug.