Bug 80686 – HTML parser: allow <hr> to be used inside <select> as a separator

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Created attachment 131013 [details]
Reproducible HTML

We have a feature that <hr> children in a <select> represent a menu separator.

http://www.webkit.org/blog/32/webkit-fixes-in-safari-202-mac-os-x-1043/
> Menu separator support: an <hr> inside a <select> with size 1 will now add a horizontal separator in the menu.

This feature doesn't work for now if such markup is parsed by the parser. It works if we insert <hr> into a <select> by a DOM operation.
Open the attached HTML, and see the difference between two popup menus.

[Dimitri Glazkov (Google)]

I think we need to change the spec first. It says that hr should be ignored: http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#parsing-main-inselect

[Adam Barth]

Or we should drop the feature if it's not implemented by other rendering engines.

[Kent Tamura]

It seems Chromium is using this feature for a popup menu in chrome://settings/fonts.

[Adam Barth]

> It seems Chromium is using this feature for a popup menu in chrome://settings/fonts.

Chromium shouldn't constrain us.  We can change Chromium to use a more wildly supported API.

[Adele Peterson]

I originally added this support for an Apple Dashboard widget that is no longer using that markup.  Unfortunately, I think there were other clients over the years.  I'll have to check to see if we have any reports about this not working in the latest Safari/OS X WebKit, but I suspect no one has noticed.

[Radar WebKit Bug Importer]

<rdar://problem/107656886>

[Anne van Kesteren]

Pull request: https://github.com/WebKit/WebKit/pull/12407

[EWS]

Committed 263624@main (d9e3a6262dbe): <https://commits.webkit.org/263624@main>

Reviewed commits have been landed. Closing PR #12407 and removing active labels.