Bug 80685 - [V8][Performance] Inline hot methods in V8Bindings.h
Summary: [V8][Performance] Inline hot methods in V8Bindings.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-09 01:36 PST by Kentaro Hara
Modified: 2012-03-09 16:13 PST (History)
4 users (show)

See Also:


Attachments
Performance tests (790 bytes, text/html)
2012-03-09 01:38 PST, Kentaro Hara
no flags Details
Patch (9.45 KB, patch)
2012-03-09 01:47 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-03-09 01:36:54 PST
We can slightly improve DOM binding performance by inlining hot methods in V8Binding.cpp, e.g. isUndefinedOrNull(), v8StringOrNull(), v8Boolean().
Comment 1 Kentaro Hara 2012-03-09 01:38:17 PST
Created attachment 131006 [details]
Performance tests
Comment 2 Kentaro Hara 2012-03-09 01:47:11 PST
Created attachment 131008 [details]
Patch
Comment 3 WebKit Review Bot 2012-03-09 16:13:31 PST
Comment on attachment 131008 [details]
Patch

Clearing flags on attachment: 131008

Committed r110347: <http://trac.webkit.org/changeset/110347>
Comment 4 WebKit Review Bot 2012-03-09 16:13:35 PST
All reviewed patches have been landed.  Closing bug.