CSSParser is doing a bunch of strange things to manage its internal CSSProperty storage. We should switch to using a normal Vector and remove the custom allocation code.
Created attachment 130934 [details] Patch
Attachment 130934 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.cpp:2738: Declaration has space between type name and * in CSSValue *value [whitespace/declaration] [3] Source/WebCore/css/CSSParser.cpp:2748: Declaration has space between type name and * in CSSValue *value [whitespace/declaration] [3] Source/WebCore/css/CSSParser.cpp:2758: Declaration has space between type name and * in CSSValue *value [whitespace/declaration] [3] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 130934 [details] Patch Nice patch. LGTM
Comment on attachment 130934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130934&action=review > Source/WebCore/css/CSSParser.cpp:8871 > + CSSProperty& property = m_parsedProperties[i]; looks like an iterator would drop in here. > Source/WebCore/css/CSSParser.cpp:9017 > + ++i; Could you use reverse iteration to get around having to retry removed indicies?
Comment on attachment 130934 [details] Patch Clearing flags on attachment: 130934 Committed r110305: <http://trac.webkit.org/changeset/110305>
All reviewed patches have been landed. Closing bug.
*** Bug 19417 has been marked as a duplicate of this bug. ***