Bug 80638 - RegionNodeList should be invalidated upon style recalc and DOM attribute changes
Summary: RegionNodeList should be invalidated upon style recalc and DOM attribute changes
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Critical
Assignee: Mihnea Ovidenie
Depends on:
Reported: 2012-03-08 14:04 PST by Ryosuke Niwa
Modified: 2017-07-18 08:26 PDT (History)
5 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-08 14:04:36 PST
Right now, RegionNodeList is only invalidated when the node is added or removed. But it should also be invalidated whenever attribute changes, or for that matter, whenever style recalc needs to happen.

Also, I really don't think we should implement this as a dynamic node list. static node list would work much better because there's virtually no use case for using the same region node list while modifying DOM or styles.
Comment 1 Ojan Vafai 2012-03-08 14:10:39 PST
We should stop propagating NodeList to new APIs. I don't think we even need static NodeLists. These should just be regular Node arrays. I suppose DOM4 should officially weigh on on that. We certainly should not add any new dynamic NodeLists to the web platform.
Comment 2 Ryosuke Niwa 2012-03-13 10:36:30 PDT
I strongly recommend we rollout the patch that implemented the regions node list. The current implementation is making the refactoring work in https://bugs.webkit.org/show_bug.cgi?id=80900 impossible.
Comment 3 Mihnea Ovidenie 2012-03-13 10:47:46 PDT
OK, i will do it asap.