Bug 80627 - [Qt][WK2] Move code common to both ProxyAuthentication and Authentication context objects into a base class
Summary: [Qt][WK2] Move code common to both ProxyAuthentication and Authentication con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-08 12:25 PST by Dinu Jacob
Modified: 2012-03-14 16:29 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.04 KB, patch)
2012-03-08 12:27 PST, Dinu Jacob
no flags Details | Formatted Diff | Diff
Patch (4.12 KB, patch)
2012-03-08 13:32 PST, Dinu Jacob
kenneth: review+
Details | Formatted Diff | Diff
Patch for landing (4.79 KB, patch)
2012-03-14 08:47 PDT, Dinu Jacob
no flags Details | Formatted Diff | Diff
To be committed (4.79 KB, patch)
2012-03-14 08:51 PDT, Dinu Jacob
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dinu Jacob 2012-03-08 12:25:00 PST
ProxyAuthenticationContextObject and AuthenticationContextObjects in QtDialogRunner shares a lot of code. Move the common code to a base that these classes can inherit from.
Comment 1 Dinu Jacob 2012-03-08 12:27:53 PST
Created attachment 130877 [details]
Patch
Comment 2 Dinu Jacob 2012-03-08 13:32:17 PST
Created attachment 130891 [details]
Patch
Comment 3 Alexander Færøy 2012-03-14 07:51:52 PDT
Comment on attachment 130891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130891&action=review

Informal r=me, but I am not a reviewer :-)

> Source/WebKit2/ChangeLog:8
> +

Maybe add a note to the ChangeLog like "This change does not affect the QML API".

> Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:101
> +class AuthenticationDialogContextObject : public BaseAuthenticationContextObject {

Maybe change this HttpAuthenticationDialogContextObject?
Comment 4 Kenneth Rohde Christiansen 2012-03-14 07:52:33 PDT
Comment on attachment 130891 [details]
Patch

Making it official
Comment 5 Dinu Jacob 2012-03-14 07:55:01 PDT
(In reply to comment #3)
> (From update of attachment 130891 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130891&action=review
> 
> Informal r=me, but I am not a reviewer :-)
> 
> > Source/WebKit2/ChangeLog:8
> > +
> 
> Maybe add a note to the ChangeLog like "This change does not affect the QML API".
> 
> > Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:101
> > +class AuthenticationDialogContextObject : public BaseAuthenticationContextObject {
> 
> Maybe change this HttpAuthenticationDialogContextObject?

Sure, will do that.
Comment 6 Alexander Færøy 2012-03-14 07:59:42 PDT
In general, I think a lot of this code could easily be cleaned up :-)
Comment 7 Dinu Jacob 2012-03-14 08:47:58 PDT
Created attachment 131861 [details]
Patch for landing
Comment 8 Alexander Færøy 2012-03-14 08:49:04 PDT
Comment on attachment 131861 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=131861&action=review

> Source/WebKit2/ChangeLog:8
> +        No impact to AML API.

Off-by-one keyboard typo.
Comment 9 Dinu Jacob 2012-03-14 08:50:14 PDT
(In reply to comment #8)
> (From update of attachment 131861 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131861&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        No impact to AML API.
> 
> Off-by-one keyboard typo.

ouch :( Will fix that! Thanks.
Comment 10 Dinu Jacob 2012-03-14 08:51:30 PDT
Created attachment 131864 [details]
To be committed
Comment 11 WebKit Review Bot 2012-03-14 16:29:22 PDT
Comment on attachment 131864 [details]
To be committed

Clearing flags on attachment: 131864

Committed r110781: <http://trac.webkit.org/changeset/110781>
Comment 12 WebKit Review Bot 2012-03-14 16:29:27 PDT
All reviewed patches have been landed.  Closing bug.