Bug 80627 – [Qt][WK2] Move code common to both ProxyAuthentication and Authentication context objects into a base class

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Dinu Jacob]

ProxyAuthenticationContextObject and AuthenticationContextObjects in QtDialogRunner shares a lot of code. Move the common code to a base that these classes can inherit from.

[Dinu Jacob]

Created attachment 130877 [details]
Patch

[Dinu Jacob]

Created attachment 130891 [details]
Patch

[Alexander Færøy]

Comment on attachment 130891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130891&action=review

Informal r=me, but I am not a reviewer :-)

> Source/WebKit2/ChangeLog:8
> +

Maybe add a note to the ChangeLog like "This change does not affect the QML API".

> Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:101
> +class AuthenticationDialogContextObject : public BaseAuthenticationContextObject {

Maybe change this HttpAuthenticationDialogContextObject?

[Kenneth Rohde Christiansen]

Comment on attachment 130891 [details]
Patch

Making it official

[Dinu Jacob]

(In reply to comment #3)
> (From update of attachment 130891 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130891&action=review
> 
> Informal r=me, but I am not a reviewer :-)
> 
> > Source/WebKit2/ChangeLog:8
> > +
> 
> Maybe add a note to the ChangeLog like "This change does not affect the QML API".
> 
> > Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:101
> > +class AuthenticationDialogContextObject : public BaseAuthenticationContextObject {
> 
> Maybe change this HttpAuthenticationDialogContextObject?

Sure, will do that.

[Alexander Færøy]

In general, I think a lot of this code could easily be cleaned up :-)

[Dinu Jacob]

Created attachment 131861 [details]
Patch for landing

[Alexander Færøy]

Comment on attachment 131861 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=131861&action=review

> Source/WebKit2/ChangeLog:8
> +        No impact to AML API.

Off-by-one keyboard typo.

[Dinu Jacob]

(In reply to comment #8)
> (From update of attachment 131861 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131861&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        No impact to AML API.
> 
> Off-by-one keyboard typo.

ouch :( Will fix that! Thanks.

[Dinu Jacob]

Created attachment 131864 [details]
To be committed

[WebKit Review Bot]

Comment on attachment 131864 [details]
To be committed

Clearing flags on attachment: 131864

Committed r110781: <http://trac.webkit.org/changeset/110781>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.