Bug 80621 - [BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp
Summary: [BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-08 11:45 PST by Nima Ghanavatian
Modified: 2012-03-08 19:05 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2012-03-08 12:09 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-03-08 11:45:47 PST 
A warning is being triggered because control can reach the end of a non-void function.  This should never happen since all the enum's are being accounted for.

I am adding an ASSERT_NOT_REACHED() and returning a valid value.
Comment 1 Nima Ghanavatian 2012-03-08 12:09:51 PST 
Created attachment 130871 [details]
Patch
Comment 2 Rob Buis 2012-03-08 12:12:14 PST 
Comment on attachment 130871 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-03-08 19:05:45 PST 
Comment on attachment 130871 [details]
Patch

Clearing flags on attachment: 130871

Committed r110249: <http://trac.webkit.org/changeset/110249>
Comment 4 WebKit Review Bot 2012-03-08 19:05:49 PST 
All reviewed patches have been landed.  Closing bug.