Bug 80612 - Remove InDocumentFlag manipulation methods from Node interface
Summary: Remove InDocumentFlag manipulation methods from Node interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-08 10:53 PST by Adam Klein
Modified: 2012-03-08 14:48 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.42 KB, patch)
2012-03-08 10:58 PST, Adam Klein 		no flags Details | Formatted Diff | Diff
Patch for landing (4.50 KB, patch)
2012-03-08 11:11 PST, Adam Klein 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2012-03-08 10:53:24 PST 
Remove InDocumentFlag manipulation methods from Node interface
Comment 1 Adam Klein 2012-03-08 10:58:11 PST 
Created attachment 130853 [details]
Patch
Comment 2 Ryosuke Niwa 2012-03-08 11:06:13 PST 
Comment on attachment 130853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130853&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::ContainerNode::removedFromDocument): Remove duplicate call to clearInDocument.

Could you clarify where the flag is cleared?
Comment 3 Adam Klein 2012-03-08 11:08:32 PST 
Comment on attachment 130853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130853&action=review

>> Source/WebCore/ChangeLog:15
>> +        (WebCore::ContainerNode::removedFromDocument): Remove duplicate call to clearInDocument.
> 
> Could you clarify where the flag is cleared?

The call to Node::removedFromDocument three lines above will clear the flag (updated my local change with this information).
Comment 4 Adam Klein 2012-03-08 11:11:36 PST 
Created attachment 130857 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-03-08 14:48:00 PST 
Comment on attachment 130857 [details]
Patch for landing

Clearing flags on attachment: 130857

Committed r110207: <http://trac.webkit.org/changeset/110207>
Comment 6 WebKit Review Bot 2012-03-08 14:48:04 PST 
All reviewed patches have been landed.  Closing bug.