Bug 80606 – [chromium] WebPluginContainer::isRectTopmost() gives incorrect result when scrolling.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Viet-Trung Luu]

[chromium] Make WebPluginContainer::isRectTopmost() only test for being above visible content.

[Viet-Trung Luu]

Created attachment 130843 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Darin Fisher (:fishd, Google)]

Comment on attachment 130843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130843&action=review

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:463
> +        if (it->get() == m_element)

what if the plugin is on a layer that is visible but positioned above an invisible layer?

[Viet-Trung Luu]

(In reply to comment #3)
> (From update of attachment 130843 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130843&action=review
> 
> > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:463
> > +        if (it->get() == m_element)
> 
> what if the plugin is on a layer that is visible but positioned above an invisible layer?

I'm not seeing the problem here. In that case, presumably only the plugin will be in the hit test results, no?

(Now, what happens if the plugin is on an invisible layer, etc.? Hmmmm.)

[Darin Fisher (:fishd, Google)]

(In reply to comment #4)
...
> I'm not seeing the problem here. In that case, presumably only the plugin will be in the hit test results, no?
> 
> (Now, what happens if the plugin is on an invisible layer, etc.? Hmmmm.)

Yeah, what you mentioned in parens is sort of what I was wondering about.  I don't fully know all of the interesting cases.  I don't understand what the hit test node set contains or doesn't contain.

[Viet-Trung Luu]

(In reply to comment #5)
> (In reply to comment #4)
> ...
> > I'm not seeing the problem here. In that case, presumably only the plugin will be in the hit test results, no?
> > 
> > (Now, what happens if the plugin is on an invisible layer, etc.? Hmmmm.)
> 
> Yeah, what you mentioned in parens is sort of what I was wondering about.  I don't fully know all of the interesting cases.  I don't understand what the hit test node set contains or doesn't contain.

The more I think about it, the odder I find that invisible layers show up in the (rect-based) hittest at all. (I'm guessing they don't show up in the non-rect-based hittests? I should check that.) That could be a bug.

More investigation needed, at any rate.

[Raymes Khoury]

The problem is that hitTestResultAtPoint() expects the point to be in document coordinates, not window coordinates.

[Raymes Khoury]

Created attachment 136772 [details]
Patch

[WebKit Review Bot]

Comment on attachment 136772 [details]
Patch

Clearing flags on attachment: 136772

Committed r114275: <http://trac.webkit.org/changeset/114275>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.