Bug 80594 - [BlackBerry] Always use the current focused node when processing focus changes
Summary: [BlackBerry] Always use the current focused node when processing focus changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-08 07:33 PST by Mike Fenton
Modified: 2012-03-08 16:32 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.17 KB, patch)
2012-03-08 07:40 PST, Mike Fenton 		no flags Details | Formatted Diff | Diff
Follow up patch (2.50 KB, patch)
2012-03-08 11:14 PST, Mike Fenton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-03-08 07:33:18 PST 
Currently in InputHandler::nodeFocused() we pass the currently focused node based on the call site.

Testing has shown that the ChromeClientBlackBerry call site which is passed the node change can be stale if JS focus changes are also occurring.  nodeFocused should always query the current focused node and use that.
Comment 1 Mike Fenton 2012-03-08 07:40:24 PST 
Created attachment 130820 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-08 10:22:13 PST 
Comment on attachment 130820 [details]
Patch

Clearing flags on attachment: 130820

Committed r110175: <http://trac.webkit.org/changeset/110175>
Comment 3 WebKit Review Bot 2012-03-08 10:22:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Mike Fenton 2012-03-08 11:14:19 PST 
Created attachment 130859 [details]
Follow up patch
Comment 5 Mike Fenton 2012-03-08 11:14:47 PST 
Re-opening as this can crash if toRange or fromRange is null.
Comment 6 WebKit Review Bot 2012-03-08 16:31:56 PST 
Comment on attachment 130859 [details]
Follow up patch

Clearing flags on attachment: 130859

Committed r110230: <http://trac.webkit.org/changeset/110230>
Comment 7 WebKit Review Bot 2012-03-08 16:32:00 PST 
All reviewed patches have been landed.  Closing bug.