Bug 80592 - Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
Summary: Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-08 06:18 PST by Mark Pilgrim (Google)
Modified: 2012-03-08 16:41 PST (History)
5 users (show)

See Also:

Attachments
Patch (12.72 KB, patch)
2012-03-08 06:21 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch with merged blocks (13.04 KB, patch)
2012-03-08 07:53 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-03-08 06:18:38 PST 
Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
Comment 1 Mark Pilgrim (Google) 2012-03-08 06:21:29 PST 
Created attachment 130815 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-03-08 06:28:08 PST 
Comment on attachment 130815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130815&action=review

> Source/WebCore/CMakeLists.txt:1691
>      LIST(APPEND WebCore_IDL_FILES
>          fileapi/FileException.idl
>          fileapi/OperationNotAllowedException.idl

Could you please merge this block with another IF (ENABLE_BLOB) section we have in line 1455 now that the check is the same?
Comment 3 Mark Pilgrim (Google) 2012-03-08 07:53:17 PST 
Created attachment 130821 [details]
Patch with merged blocks
Comment 4 Adam Barth 2012-03-08 14:29:02 PST 
Comment on attachment 130821 [details]
Patch with merged blocks

Thanks.
Comment 5 WebKit Review Bot 2012-03-08 16:41:38 PST 
Comment on attachment 130821 [details]
Patch with merged blocks

Clearing flags on attachment: 130821

Committed r110231: <http://trac.webkit.org/changeset/110231>
Comment 6 WebKit Review Bot 2012-03-08 16:41:43 PST 
All reviewed patches have been landed.  Closing bug.