Bug 80592 - Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
: Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-03-08 06:18 PST by
Modified: 2012-03-08 16:41 PST (History)


Attachments
Patch (12.72 KB, patch)
2012-03-08 06:21 PST, Mark Pilgrim (Google)
no flags Review Patch | Details | Formatted Diff | Diff
Patch with merged blocks (13.04 KB, patch)
2012-03-08 07:53 PST, Mark Pilgrim (Google)
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-03-08 06:18:38 PST
Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
------- Comment #1 From 2012-03-08 06:21:29 PST -------
Created an attachment (id=130815) [details]
Patch
------- Comment #2 From 2012-03-08 06:28:08 PST -------
(From update of attachment 130815 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=130815&action=review

> Source/WebCore/CMakeLists.txt:1691
>      LIST(APPEND WebCore_IDL_FILES
>          fileapi/FileException.idl
>          fileapi/OperationNotAllowedException.idl

Could you please merge this block with another IF (ENABLE_BLOB) section we have in line 1455 now that the check is the same?
------- Comment #3 From 2012-03-08 07:53:17 PST -------
Created an attachment (id=130821) [details]
Patch
------- Comment #4 From 2012-03-08 14:29:02 PST -------
(From update of attachment 130821 [details])
Thanks.
------- Comment #5 From 2012-03-08 16:41:38 PST -------
(From update of attachment 130821 [details])
Clearing flags on attachment: 130821

Committed r110231: <http://trac.webkit.org/changeset/110231>
------- Comment #6 From 2012-03-08 16:41:43 PST -------
All reviewed patches have been landed.  Closing bug.