Bug 80584 - [chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status
Summary: [chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initia...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nat Duca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-08 02:43 PST by Nat Duca
Modified: 2012-03-08 19:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.21 KB, patch)
2012-03-08 02:44 PST, Nat Duca 		no flags Details | Formatted Diff | Diff
null check during initialize (3.23 KB, patch)
2012-03-08 03:47 PST, Nat Duca 		no flags Details | Formatted Diff | Diff
Normalize SingleThreadProxy behavior also (4.04 KB, patch)
2012-03-08 14:30 PST, Nat Duca 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2012-03-08 02:43:40 PST 
[chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status
Comment 1 Nat Duca 2012-03-08 02:44:12 PST 
Created attachment 130799 [details]
Patch
Comment 2 Nat Duca 2012-03-08 02:46:57 PST 
As part of re-working the compositeAndReadback flow, I am trying to write a unit test that fails for the existing broken case. In doing that, I got bitten by the visibility call behaving differently during initialization. So, I'm thinking, can we just make it all the time?
Comment 3 Nat Duca 2012-03-08 03:47:14 PST 
Created attachment 130804 [details]
null check during initialize
Comment 4 James Robinson 2012-03-08 11:09:20 PST 
Comment on attachment 130804 [details]
null check during initialize

View in context: https://bugs.webkit.org/attachment.cgi?id=130804&action=review

OK

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:399
> +    if (visible && m_layerRenderer && m_layerRenderer->capabilities().usingPartialSwap)

since we're also null checking m_layerRenderer on line 394 probably better to just null check it and return above that line instead of checking it twice
Comment 5 Nat Duca 2012-03-08 14:30:23 PST 
Created attachment 130907 [details]
Normalize SingleThreadProxy behavior also
Comment 6 Nat Duca 2012-03-08 14:30:53 PST 
Comment on attachment 130907 [details]
Normalize SingleThreadProxy behavior also

Putting r? again because I made a similar change to CCSingleThreadProxy::setVisible
Comment 7 James Robinson 2012-03-08 15:08:54 PST 
Comment on attachment 130907 [details]
Normalize SingleThreadProxy behavior also

OK
Comment 8 WebKit Review Bot 2012-03-08 19:52:41 PST 
Comment on attachment 130907 [details]
Normalize SingleThreadProxy behavior also

Clearing flags on attachment: 130907

Committed r110255: <http://trac.webkit.org/changeset/110255>
Comment 9 WebKit Review Bot 2012-03-08 19:52:46 PST 
All reviewed patches have been landed.  Closing bug.