Bug 80582 – Make check-webkit-style complain about "No new tests (OOPS)" lines in changelogs

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nat Duca]

Make check-webkit-style complain about "No new tests (OOPS)" lines in changelogs

[Nat Duca]

Created attachment 130798 [details]
Patch

[David Levin]

Comment on attachment 130798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130798&action=review

> Tools/Scripts/webkitpy/style/checkers/changelog.py:78
> +                                        "Need whitespace between colon and description")

I don't think this is what you want the error to say.

[Nat Duca]

Created attachment 130849 [details]
Patch for landing

[David Levin]

You can re-add cq+ but I wanted to say this which I should have said before.

Many times when I've seen people have this they are new and need guidance.

The typical guidance is "You should remove the 'No new tests' and either add tests and list them here or explain why no new tests were possible which may be due to the fact that n'N change in behavior happened so no new tests'."

Apologies for not saying this before. You may leave it as is or add something more directed like I did above.

[Nat Duca]

Great idea! I'll adjust the text accordingly.

(In reply to comment #4)
> You can re-add cq+ but I wanted to say this which I should have said before.
> 
> Many times when I've seen people have this they are new and need guidance.
> 
> The typical guidance is "You should remove the 'No new tests' and either add tests and list them here or explain why no new tests were possible which may be due to the fact that n'N change in behavior happened so no new tests'."
> 
> Apologies for not saying this before. You may leave it as is or add something more directed like I did above.

[Nat Duca]

Created attachment 130866 [details]
Patch

[Nat Duca]

Comment on attachment 130866 [details]
Patch

Hows this?

[WebKit Review Bot]

Comment on attachment 130866 [details]
Patch

Rejecting attachment 130866 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 124103 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 124103.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11898241

[Nat Duca]

Created attachment 131014 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 131014 [details]
Patch for landing

Clearing flags on attachment: 131014

Committed r110282: <http://trac.webkit.org/changeset/110282>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.