Bug 80576 – CSS 2.1 failure: text-indent-intrinsic-003 fails

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Robert Hogan]

When there are two consecutive empty <span> blocks, text-indent is ignored for the second one even though it is still on the first formatted line.

[Robert Hogan]

The problem appears to be in computeInlinePreferredLogicalWidths(): textIndent is currently only added once, to the first object on the formatted line. Instead it needs to be applied to each object on the first formatted line and decremented appropriately each time.

[Robert Hogan]

Created attachment 152421 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 152421 [details]
Patch

Seems reasonable.

[WebKit Review Bot]

Comment on attachment 152421 [details]
Patch

Rejecting attachment 152421 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp
Failed to merge in the changes.
Patch failed at 0001 [chromium] Fix style for numeric literals in chromium unit test code

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13276622

[Robert Hogan]

Created attachment 153070 [details]
Patch

[WebKit Review Bot]

Comment on attachment 153070 [details]
Patch

Rejecting attachment 153070 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 63.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13305001

[Robert Hogan]

Committed r123130: <http://trac.webkit.org/changeset/123130>