Bug 80565 - [Chromium] Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled.
Summary: [Chromium] Allow CCLayerTreeHost::context() to be called even with the thread...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ami Fischman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-07 21:09 PST by Ami Fischman
Modified: 2012-03-07 22:55 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2012-03-07 21:11 PST, Ami Fischman 		no flags Details | Formatted Diff | Diff
Patch (3.43 KB, patch)
2012-03-07 21:24 PST, Ami Fischman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ami Fischman 2012-03-07 21:09:12 PST 
Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled.
Comment 1 Ami Fischman 2012-03-07 21:11:05 PST 
Created attachment 130758 [details]
Patch
Comment 2 James Robinson 2012-03-07 21:13:33 PST 
Comment on attachment 130758 [details]
Patch

I should you should also update the various comments around this function (and the functions that call into this) to clearly document the expectations of this return value - i.e. you can't make any GL calls or make the context current unless you know you're on the thread the compositor is running on.
Comment 3 Ami Fischman 2012-03-07 21:24:36 PST 
Created attachment 130762 [details]
Patch
Comment 4 WebKit Review Bot 2012-03-07 21:25:54 PST 
Please wait for approval from fishd@chromium.org, abarth@webkit.org or jamesr@chromium.org before submitting because this patch contains changes to the Chromium platform API.
Comment 5 James Robinson 2012-03-07 21:25:57 PST 
Comment on attachment 130762 [details]
Patch

Cool, I think that's sufficiently scary.
Comment 6 WebKit Review Bot 2012-03-07 22:55:52 PST 
Comment on attachment 130762 [details]
Patch

Clearing flags on attachment: 130762

Committed r110149: <http://trac.webkit.org/changeset/110149>
Comment 7 WebKit Review Bot 2012-03-07 22:55:57 PST 
All reviewed patches have been landed.  Closing bug.