IndexedDB: layout test style update
Created attachment 130735 [details] Patch
Created attachment 130739 [details] Patch
Josh, can you take a look at this? There are only two -expected.txt changes, both for js line numbers. Next patch is going to move all the indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;"); shouldBeFalse("indexedDB == null"); IDBDatabaseException = evalAndLog("IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;"); ... lines to a function in shared.js that uses self instead of window.
Comment on attachment 130739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130739&action=review > LayoutTests/storage/indexeddb/mozilla/autoincrement-indexes.html:89 > function checkThirdIndex() this file still has the if (window.layoutTestController) ... preamble - needed? > LayoutTests/storage/indexeddb/mozilla/bad-keypath.html:55 > function addFirstSuccess() ditto - if (window.layoutTestController) ... Was it accidentally left in the mozilla/ tests, or is it needed for some reason?
Created attachment 130922 [details] Patch
> ditto - if (window.layoutTestController) ... > > Was it accidentally left in the mozilla/ tests, or is it needed for some reason? Accident - fixed.
Created attachment 130924 [details] Patch Deleted few more stray lines
Comment on attachment 130924 [details] Patch lgtm
Tony, could you review this?
Comment on attachment 130924 [details] Patch rs=me
Comment on attachment 130924 [details] Patch Clearing flags on attachment: 130924 Committed r110468: <http://trac.webkit.org/changeset/110468>
All reviewed patches have been landed. Closing bug.