Bug 8055 - Fix most CSS grammar conflicts
Summary: Fix most CSS grammar conflicts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 6380
  Show dependency treegraph
 
Reported: 2006-03-29 08:27 PST by Alexey Proskuryakov
Modified: 2006-03-29 09:35 PST (History)
0 users

See Also:


Attachments
proposed patch (6.17 KB, patch)
2006-03-29 08:29 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2006-03-29 08:27:32 PST
Bison currently reports 37+4 shift/reduce and reduce/reduce conflicts, this patch gets the number down to 7+0.

I have fixed the reduce/reduce conflicts, then noticed that two of the fixes were already made in KDE tree (the other two are different because declaration blocks are described in quite different ways). Shift/reduce fixes are just merged from KDE, r332845 by Michael Matz.
Comment 1 Alexey Proskuryakov 2006-03-29 08:29:10 PST
Created attachment 7373 [details]
proposed patch
Comment 2 Darin Adler 2006-03-29 08:39:45 PST
Comment on attachment 7373 [details]
proposed patch

It's a little strange to give a space and a selector the same precedence as the "unimportant" token. I see that it might work, but it seems a bit obscure or subtle.

But that's a nitpick. This change looks great! r=me
Comment 3 Alexey Proskuryakov 2006-03-29 09:35:22 PST
(In reply to comment #2)

The precedence changes are only needed for shift/reduce fixes, taken from KDE. I cannot say that I understood them particularly well.

Landed, r13560.