Bug 80541 - Implement getAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Summary: Implement getAttributeNode() in terms of ElementAttributeData instead of Name...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks: 75069
  Show dependency treegraph
 
Reported: 2012-03-07 14:22 PST by Caio Marcelo de Oliveira Filho
Modified: 2012-03-07 19:57 PST (History)
1 user (show)

See Also:


Attachments
Patch (7.73 KB, patch)
2012-03-07 14:27 PST, Caio Marcelo de Oliveira Filho
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2012-03-07 14:22:08 PST
Implement getAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Comment 1 Caio Marcelo de Oliveira Filho 2012-03-07 14:27:39 PST
Created attachment 130693 [details]
Patch
Comment 2 Ryosuke Niwa 2012-03-07 15:32:46 PST
Comment on attachment 130693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130693&action=review

> Source/WebCore/dom/ElementAttributeData.h:159
> +    Attribute* a = getAttributeItem(name, shouldIgnoreAttributeCase);

Please don't use one-letter abbreviations like "a". Instead, spell-out attribute.

> Source/WebCore/dom/ElementAttributeData.h:168
> +    Attribute* a = getAttributeItem(name);

Ditto.
Comment 3 Caio Marcelo de Oliveira Filho 2012-03-07 15:58:08 PST
Committed r110119: <http://trac.webkit.org/changeset/110119>