Bug 80529 – Web Inspector: Creating a selector for class names with trailing spaces results with two dots instead of one

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Nikita Vasilyev]

Screencast http://www.screenr.com/Ug78

Expected selector: ".dummy"
Actual: "..dummy"

[Vivek Galatage]

The problem is with Source/WebCore/inspector/front-end/DOMAgent.js file's method appropriateSelectorFor. This is the method which chooses the appropriate selector for the currently selected node in the Element view.

So now as the existing class has a trailing spaces i.e. " dummy" the function misses to remove this space at the beginning and goes on prefixing the . before the className variable.

Also the regular expression removes the white spaces with "." so it appears twice  when added.

So this has to be trimmed before using. 

The change is on the line no 348 and change it as below -

var selector = "." + className.trim().replace(/\s+/, ".");

Will upload the patch for this fix soon.

Thank you,
Vivek

[Vivek Galatage]

Created attachment 130834 [details]
Patch

[WebKit Review Bot]

Comment on attachment 130834 [details]
Patch

Rejecting attachment 130834 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 130834 [details]
Patch

Rejecting attachment 130834 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Vivek Galatage]

Created attachment 130851 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 130851 [details]
Patch

Is there a way to create an automated test for this?

[Pavel Feldman]

Comment on attachment 130851 [details]
Patch

Nit: this could have a test.

[Pavel Feldman]

@aroben: either Alexander or myself will follow up with the test.

[WebKit Review Bot]

Comment on attachment 130851 [details]
Patch

Clearing flags on attachment: 130851

Committed r110198: <http://trac.webkit.org/changeset/110198>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.