Bug 80522 - Implement removeAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Summary: Implement removeAttributeNode() in terms of ElementAttributeData instead of N...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks: 75069
  Show dependency tree / graph
 
Reported: 2012-03-07 11:00 PST by Caio Marcelo de Oliveira Filho
Modified: 2012-03-07 19:57 PST (History)
0 users

See Also:

Attachments
Patch (7.64 KB, patch)
2012-03-07 11:07 PST, Caio Marcelo de Oliveira Filho 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2012-03-07 11:00:05 PST 
Implement removeAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Comment 1 Caio Marcelo de Oliveira Filho 2012-03-07 11:07:50 PST 
Created attachment 130651 [details]
Patch
Comment 2 Andreas Kling 2012-03-07 11:26:10 PST 
Comment on attachment 130651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130651&action=review

r=me

> Source/WebCore/dom/Element.cpp:192
>      if (!m_attributeMap)
>          return;
>  
> -    m_attributeMap->removeAttribute(name);
> +    m_attributeMap->attributeData()->removeAttribute(name, this);

You could bypass m_attributeMap entirely here and just use Element::attributeData().
Comment 3 Caio Marcelo de Oliveira Filho 2012-03-07 12:38:04 PST 
Committed r110086: <http://trac.webkit.org/changeset/110086>