Bug 80510 - Web Inspector crash (iCab)
Summary: Web Inspector crash (iCab)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-07 06:27 PST by trinler
Modified: 2012-03-07 15:31 PST (History)
11 users (show)

See Also:

Attachments
two iCab crashlogs (r110001 and r110047) (18.97 KB, application/zip)
2012-03-07 06:27 PST, trinler 		no flags Details
[PATCH] Proposed Fix (1.17 KB, patch)
2012-03-07 14:29 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description trinler 2012-03-07 06:27:05 PST 
Created attachment 130611 [details]
two iCab crashlogs (r110001 and r110047)

Steps to reproduce (r110001):

- in iCab open blank page
- open Inspector
- close inspector
=> crash

Steps to reproduce (r110047):

- in iCab open blank page
- open Inspector
=> crash

crash happens only in iCab, not reproducible with Safari.
no problems with r109934, problem started with r110001.
Comment 1 Alexey Proskuryakov 2012-03-07 11:34:30 PST 
Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x0000000100cbd3ea WebCore::InspectorFrontendClientLocal::canAttachWindow() + 10
1   com.apple.WebKit              	0x00000001002f8a82 WebInspectorClient::didResizeMainFrame(WebCore::Frame*) + 18
2   com.apple.WebCore             	0x0000000100b53bd3 WebCore::FrameView::layout(bool) + 2643
3   com.apple.WebKit              	0x00000001002eb1b5 -[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:] + 341
4   com.apple.WebKit              	0x00000001002b7d71 -[WebDynamicScrollBarsView(WebInternal) updateScrollers] + 161
...
Comment 2 Joseph Pecoraro 2012-03-07 11:50:28 PST 
I just added didResizeMainFrame in r109939, so this is likely due to what I just added. I'll take a look.
Comment 3 Joseph Pecoraro 2012-03-07 14:29:28 PST 
Created attachment 130694 [details]
[PATCH] Proposed Fix

Took me more than a couple full builds to test the WK1 path properly. Sorry about that!
Comment 4 WebKit Review Bot 2012-03-07 15:31:17 PST 
Comment on attachment 130694 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 130694

Committed r110116: <http://trac.webkit.org/changeset/110116>
Comment 5 WebKit Review Bot 2012-03-07 15:31:22 PST 
All reviewed patches have been landed.  Closing bug.