Bug 80510 – Web Inspector crash (iCab)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

Created attachment 130611 [details]
two iCab crashlogs (r110001 and r110047)

Steps to reproduce (r110001):

- in iCab open blank page
- open Inspector
- close inspector
=> crash

Steps to reproduce (r110047):

- in iCab open blank page
- open Inspector
=> crash

crash happens only in iCab, not reproducible with Safari.
no problems with r109934, problem started with r110001.

[Alexey Proskuryakov]

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x0000000100cbd3ea WebCore::InspectorFrontendClientLocal::canAttachWindow() + 10
1   com.apple.WebKit              	0x00000001002f8a82 WebInspectorClient::didResizeMainFrame(WebCore::Frame*) + 18
2   com.apple.WebCore             	0x0000000100b53bd3 WebCore::FrameView::layout(bool) + 2643
3   com.apple.WebKit              	0x00000001002eb1b5 -[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:] + 341
4   com.apple.WebKit              	0x00000001002b7d71 -[WebDynamicScrollBarsView(WebInternal) updateScrollers] + 161
...

[Joseph Pecoraro]

I just added didResizeMainFrame in r109939, so this is likely due to what I just added. I'll take a look.

[Joseph Pecoraro]

Created attachment 130694 [details]
[PATCH] Proposed Fix

Took me more than a couple full builds to test the WK1 path properly. Sorry about that!

[WebKit Review Bot]

Comment on attachment 130694 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 130694

Committed r110116: <http://trac.webkit.org/changeset/110116>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.