RESOLVED FIXED 80505
Linux has madvise enough to support OSAllocator::commit/decommit 
https://bugs.webkit.org/show_bug.cgi?id=80505
Summary Linux has madvise enough to support OSAllocator::commit/decommit
Hojong Han
Reported 2012-03-07 03:17:13 PST
Linux has madvise enough to support OSAllocator::commit/decommit, but it's not used in commit and decommit. What about using this function with OS(LINUX) option?
Attachments
Patch (2.25 KB, patch)
2012-03-07 03:30 PST, Hojong Han 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hojong Han
Comment 1 2012-03-07 03:30:24 PST
Created attachment 130587 [details] Patch
Geoffrey Garen
Comment 2 2012-03-07 12:32:16 PST
Comment on attachment 130587 [details] Patch r=me
Hojong Han
Comment 3 2012-03-14 21:12:52 PDT
Thanks for review. Isn't it necessary to put it in the queue? Is there anything to do more? Please let me know.
WebKit Review Bot
Comment 4 2012-03-15 12:54:29 PDT
Comment on attachment 130587 [details] Patch Clearing flags on attachment: 130587 Committed r110874: <http://trac.webkit.org/changeset/110874>
WebKit Review Bot
Comment 5 2012-03-15 12:54:34 PDT
All reviewed patches have been landed. Closing bug.
Patrick R. Gansterer
Comment 6 2012-03-15 13:27:44 PDT
Comment on attachment 130587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130587&action=review > Source/JavaScriptCore/wtf/OSAllocatorPosix.cpp:145 > + madvise(address, bytes, MADV_DONTNEED); what's the difference between this line and the line guarded with HAVE(MADV_DONTNEED)? can't we merge them or at least follow the "style" of the other lines?
Note You need to log in before you can comment on or make changes to this bug.