Bug 80504 - Web Inspector: console.log attempts to substitute any "%" character in the message.
Summary: Web Inspector: console.log attempts to substitute any "%" character in the me...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-07 02:24 PST by Pavel Feldman
Modified: 2012-03-11 10:34 PDT (History)
11 users (show)

See Also:

Attachments
Patch (9.92 KB, patch)
2012-03-07 03:55 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (10.23 KB, patch)
2012-03-11 09:12 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-03-07 02:24:56 PST 
Downstream issue: http://code.google.com/p/chromium/issues/detail?id=111021
Comment 1 Pavel Feldman 2012-03-07 03:55:49 PST 
Created attachment 130592 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-11 05:08:53 PDT 
Comment on attachment 130592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130592&action=review

> Source/WebCore/inspector/front-end/utilities.js:811
> +        if (!(format[index] in formatters)) {

This will break strings like "foo%555 bar"
Comment 3 Pavel Feldman 2012-03-11 09:12:42 PDT 
Created attachment 131228 [details]
Patch
Comment 4 WebKit Review Bot 2012-03-11 10:34:24 PDT 
Comment on attachment 131228 [details]
Patch

Clearing flags on attachment: 131228

Committed r110395: <http://trac.webkit.org/changeset/110395>
Comment 5 WebKit Review Bot 2012-03-11 10:34:29 PDT 
All reviewed patches have been landed.  Closing bug.