Bug 80493 - Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth()
Summary: Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 80479
  Show dependency treegraph
 
Reported: 2012-03-06 22:55 PST by Kent Tamura
Modified: 2012-03-07 19:03 PST (History)
5 users (show)

See Also:


Attachments
Patch (11.01 KB, patch)
2012-03-06 23:15 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 2 (11.87 KB, patch)
2012-03-07 05:18 PST, Kent Tamura
morrita: review+
morrita: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-03-06 22:55:16 PST
Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth()
Comment 1 Kent Tamura 2012-03-06 23:15:42 PST
Created attachment 130551 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-07 02:19:38 PST
Comment on attachment 130551 [details]
Patch 

Attachment 130551 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11838879
Comment 3 Kent Tamura 2012-03-07 05:18:27 PST
Created attachment 130602 [details]
Patch 2

Chromium build fix
Comment 4 Hajime Morrita 2012-03-07 18:03:56 PST
Comment on attachment 130602 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=130602&action=review

Looks good. My guess is that there is more code like this which was used a source of  this change....

> Source/WebCore/ChangeLog:13
> +        The default borders and paddings of these buttons are 0, this code was

Want some conjunction here to clarify the connection.
Comment 5 Kent Tamura 2012-03-07 19:01:17 PST
(In reply to comment #4)
> > +        The default borders and paddings of these buttons are 0, this code was
> 
> Want some conjunction here to clarify the connection.

I updated ChangeLog, and am landing.
Comment 6 Kent Tamura 2012-03-07 19:03:04 PST
Committed r110130: <http://trac.webkit.org/changeset/110130>