Bug 80488 - Rename NotificationPresenter to NotificationClient
Summary: Rename NotificationPresenter to NotificationClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.7
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks: 80472 90370
  Show dependency treegraph
 
Reported: 2012-03-06 21:53 PST by Jon Lee
Modified: 2012-07-02 03:03 PDT (History)
4 users (show)

See Also:


Attachments
WIP (60.96 KB, patch)
2012-03-09 13:51 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (61.32 KB, patch)
2012-03-09 15:12 PST, Jon Lee
no flags Details | Formatted Diff | Diff
WIP (62.04 KB, patch)
2012-03-09 22:07 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (73.08 KB, patch)
2012-03-09 23:42 PST, Jon Lee
haraken: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2012-03-06 21:53:59 PST
The name NotificationPresenter doesn't match the naming pattern for other features like geolocation. Should rename as NotificationClient.

<rdar://problem/10965558>
Comment 1 Jon Lee 2012-03-09 13:51:42 PST
Created attachment 131098 [details]
WIP
Comment 2 WebKit Review Bot 2012-03-09 13:57:12 PST
Attachment 131098 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1
Source/WebCore/notifications/NotificationCenter.cpp:54:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/notifications/NotificationClient.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2012-03-09 14:41:15 PST
Comment on attachment 131098 [details]
WIP

Attachment 131098 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/11915707
Comment 4 Early Warning System Bot 2012-03-09 15:01:05 PST
Comment on attachment 131098 [details]
WIP

Attachment 131098 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11911767
Comment 5 Jon Lee 2012-03-09 15:12:01 PST
Created attachment 131121 [details]
Patch
Comment 6 WebKit Review Bot 2012-03-09 15:13:59 PST
Attachment 131121 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1
Source/WebCore/notifications/NotificationCenter.cpp:54:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/notifications/NotificationClient.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Jon Lee 2012-03-09 22:07:33 PST
Created attachment 131153 [details]
WIP
Comment 8 WebKit Review Bot 2012-03-09 22:10:23 PST
Attachment 131153 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1
Source/WebCore/notifications/NotificationCenter.cpp:54:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/notifications/NotificationClient.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Jon Lee 2012-03-09 23:42:21 PST
Created attachment 131160 [details]
Patch
Comment 10 Kentaro Hara 2012-03-10 03:14:28 PST
Comment on attachment 131160 [details]
Patch

Looks OK. This patch will conflict with my patch (https://bugs.webkit.org/show_bug.cgi?id=79636). Let's commit this patch first.
Comment 11 Jon Lee 2012-03-10 10:43:20 PST
Committed r110381: http://trac.webkit.org/changeset/110381