The name NotificationPresenter doesn't match the naming pattern for other features like geolocation. Should rename as NotificationClient. <rdar://problem/10965558>
Created attachment 131098 [details] WIP
Attachment 131098 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.cpp:54: Missing space inside { }. [whitespace/braces] [5] Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/NotificationClient.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 131098 [details] WIP Attachment 131098 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/11915707
Comment on attachment 131098 [details] WIP Attachment 131098 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11911767
Created attachment 131121 [details] Patch
Attachment 131121 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.cpp:54: Missing space inside { }. [whitespace/braces] [5] Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/NotificationClient.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 131153 [details] WIP
Attachment 131153 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.cpp:54: Missing space inside { }. [whitespace/braces] [5] Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/NotificationClient.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 131160 [details] Patch
Comment on attachment 131160 [details] Patch Looks OK. This patch will conflict with my patch (https://bugs.webkit.org/show_bug.cgi?id=79636). Let's commit this patch first.
Committed r110381: http://trac.webkit.org/changeset/110381