Bug 80487 – Move NotificationContents into Notification

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Jon Lee]

Splitting out the data members for text notifications is unnecessary. Move those data members (title, body, URL) back into Notification, and remove NotificationContents from WebCore.

<rdar://problem/10965519>

[Jon Lee]

Created attachment 130737 [details]
Patch

[Build Bot]

Comment on attachment 130737 [details]
Patch

Attachment 130737 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11862037

[Early Warning System Bot]

Comment on attachment 130737 [details]
Patch

Attachment 130737 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11863083

[WebKit Review Bot]

Comment on attachment 130737 [details]
Patch

Attachment 130737 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11865076

[Jon Lee]

Created attachment 130761 [details]
Patch

[Early Warning System Bot]

Comment on attachment 130761 [details]
Patch

Attachment 130761 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11866121

[WebKit Review Bot]

Comment on attachment 130761 [details]
Patch

Attachment 130761 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11861150

[Jon Lee]

Created attachment 130772 [details]
Patch

[Jon Lee]

Created attachment 131177 [details]
Patch

[Jon Lee]

Created attachment 131186 [details]
Patch

[Jian Li]

Comment on attachment 131186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131186&action=review

> Source/WebCore/notifications/Notification.h:77
> +    KURL iconURL() { return m_icon; }

Please add const modifier.

> Source/WebCore/notifications/Notification.h:79
> +    void setTitle(const String& title) { m_title = title; }

It seems that none is accessing setTitle and setBody now. Will they be used in the future patch?

[Jon Lee]

(In reply to comment #11)
> (From update of attachment 131186 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131186&action=review
> 
> > Source/WebCore/notifications/Notification.h:77
> > +    KURL iconURL() { return m_icon; }
> 
> Please add const modifier.
Sure.

> 
> > Source/WebCore/notifications/Notification.h:79
> > +    void setTitle(const String& title) { m_title = title; }
> 
> It seems that none is accessing setTitle and setBody now. Will they be used in the future patch?
Not at this point. I can remove.

[Jon Lee]

Committed r110903: <http://trac.webkit.org/changeset/110903>