Splitting out the data members for text notifications is unnecessary. Move those data members (title, body, URL) back into Notification, and remove NotificationContents from WebCore. <rdar://problem/10965519>
Created attachment 130737 [details] Patch
Comment on attachment 130737 [details] Patch Attachment 130737 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11862037
Comment on attachment 130737 [details] Patch Attachment 130737 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11863083
Comment on attachment 130737 [details] Patch Attachment 130737 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11865076
Created attachment 130761 [details] Patch
Comment on attachment 130761 [details] Patch Attachment 130761 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11866121
Comment on attachment 130761 [details] Patch Attachment 130761 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11861150
Created attachment 130772 [details] Patch
Created attachment 131177 [details] Patch
Created attachment 131186 [details] Patch
Comment on attachment 131186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131186&action=review > Source/WebCore/notifications/Notification.h:77 > + KURL iconURL() { return m_icon; } Please add const modifier. > Source/WebCore/notifications/Notification.h:79 > + void setTitle(const String& title) { m_title = title; } It seems that none is accessing setTitle and setBody now. Will they be used in the future patch?
(In reply to comment #11) > (From update of attachment 131186 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131186&action=review > > > Source/WebCore/notifications/Notification.h:77 > > + KURL iconURL() { return m_icon; } > > Please add const modifier. Sure. > > > Source/WebCore/notifications/Notification.h:79 > > + void setTitle(const String& title) { m_title = title; } > > It seems that none is accessing setTitle and setBody now. Will they be used in the future patch? Not at this point. I can remove.
Committed r110903: <http://trac.webkit.org/changeset/110903>