Bug 80474 – Web Inspector: Cannot insert right curly bracket on some keyboards

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Cem Kocagil]

Right curly brackets cannot be typed on keyboards where the right curly bracket is inserted by using AltGr+0. Instead, this combination has the same effect as ctrl+0 (reset zoom).

The changeset that causes the bug: http://trac.webkit.org/changeset/108794/

Patch is on the way

[Cem Kocagil]

Created attachment 130523 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 130523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130523&action=review

> Source/WebCore/inspector/front-end/inspector.js:720
> +    var hasCtrlOrMeta = WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) && !event.shiftKey && !event.altKey;

I would rename the variable into something like "hasOnlyCtrlOrMeta" in order to differentiate it from the "normal" hasCtrlOrMeta checks around the code. Otherwise looks good; thanks for diagnosing and fixing this.

[Pavel Feldman]

Comment on attachment 130523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130523&action=review

>> Source/WebCore/inspector/front-end/inspector.js:720
>> +    var hasCtrlOrMeta = WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) && !event.shiftKey && !event.altKey;
> 
> I would rename the variable into something like "hasOnlyCtrlOrMeta" in order to differentiate it from the "normal" hasCtrlOrMeta checks around the code. Otherwise looks good; thanks for diagnosing and fixing this.

Thanks for looking into it. As Alexander suggests, I'd move hasCtrlOrMeta closer to its usage (below the first switch), combined it with the !InspectorFrontendHost.isStub and renamed to something like isValidZoomShortcut.

[Cem Kocagil]

Created attachment 130631 [details]
Patch

[Cem Kocagil]

Updated, waiting for review

[WebKit Review Bot]

Comment on attachment 130631 [details]
Patch

Clearing flags on attachment: 130631

Committed r110192: <http://trac.webkit.org/changeset/110192>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.