WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
80473
check-webkit-style should warn about "XCode" vs "Xcode"
https://bugs.webkit.org/show_bug.cgi?id=80473
Summary
check-webkit-style should warn about "XCode" vs "Xcode"
Eric Seidel (no email)
Reported
2012-03-06 19:31:48 PST
check-webkit-style should warn about "XCode" vs "Xcode" Everyone gets it wrong. And reviewers shouldn't have to notice this sort of thing. :)
Attachments
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2012-03-06 19:33:47 PST
OSX vs OS X would be another good one to catch too.
Eric Seidel (no email)
Comment 2
2012-03-06 19:37:47 PST
My belief is that if reviewers are going to comment on these things (I'm personally agnostic), than we should make the tools worry about it, instead of reviewers. That theoretically allows reviewers to only have to worry about the important stuff. We should add a couple of these, and see how we feel. It should be super easy to generalize. Gtk and Qt reviewers might be commenting on capitalization of those as well (I don't know). If that's the case, we should make the tools complain about the ones we care about and (hopefully) ignore the rest. :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug