Bug 80469 - [CMake] Make the removal of transitive library dependencies work with CMake < 2.8.7.
Summary: [CMake] Make the removal of transitive library dependencies work with CMake <...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 18:32 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2012-03-06 23:37 PST (History)
7 users (show)

See Also:


Attachments
Proposed patch (7.52 KB, patch)
2012-03-06 18:36 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-03-06 18:32:37 PST
Sorry, but I had not noticed the CMAKE_LINK_INTERFACE_LIBRARIES variable I use in r109983 was introduced in CMake 2.8.7, so the build is still broken on popular distros which have earlier CMake versions (at least Ubuntu and Fedora, I guess). For now, we need to manually set the LINK_INTERFACE_LIBRARIES property on each target.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-03-06 18:36:31 PST
Created attachment 130515 [details]
Proposed patch
Comment 2 Antonio Gomes 2012-03-06 19:27:39 PST
Comment on attachment 130515 [details]
Proposed patch

ok
Comment 3 WebKit Review Bot 2012-03-06 23:37:36 PST
Comment on attachment 130515 [details]
Proposed patch

Clearing flags on attachment: 130515

Committed r110024: <http://trac.webkit.org/changeset/110024>
Comment 4 WebKit Review Bot 2012-03-06 23:37:40 PST
All reviewed patches have been landed.  Closing bug.