WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
80469
[CMake] Make the removal of transitive library dependencies work with CMake < 2.8.7.
https://bugs.webkit.org/show_bug.cgi?id=80469
Summary
[CMake] Make the removal of transitive library dependencies work with CMake <...
Raphael Kubo da Costa (:rakuco)
Reported
2012-03-06 18:32:37 PST
Sorry, but I had not noticed the CMAKE_LINK_INTERFACE_LIBRARIES variable I use in
r109983
was introduced in CMake 2.8.7, so the build is still broken on popular distros which have earlier CMake versions (at least Ubuntu and Fedora, I guess). For now, we need to manually set the LINK_INTERFACE_LIBRARIES property on each target.
Attachments
Proposed patch
(7.52 KB, patch)
2012-03-06 18:36 PST
,
Raphael Kubo da Costa (:rakuco)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1
2012-03-06 18:36:31 PST
Created
attachment 130515
[details]
Proposed patch
Antonio Gomes
Comment 2
2012-03-06 19:27:39 PST
Comment on
attachment 130515
[details]
Proposed patch ok
WebKit Review Bot
Comment 3
2012-03-06 23:37:36 PST
Comment on
attachment 130515
[details]
Proposed patch Clearing flags on attachment: 130515 Committed
r110024
: <
http://trac.webkit.org/changeset/110024
>
WebKit Review Bot
Comment 4
2012-03-06 23:37:40 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug