According to the specification[1], the "output" element is a labelable. * FF=FAIL * IE=FAIL * OP=PASS Sample URI(http://jsfiddle.net/FP5ur/) should output only "Output(1)". [1] http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#category-label
Created attachment 130752 [details] Patch 1
Comment on attachment 130752 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=130752&action=review > LayoutTests/fast/forms/output/output-labels.html:1 > +<script src="../../js/resources/js-test-pre.js"></script> The test coverage is not good. I recommend you add "output" cases to existing fast/forms/labels-* tests. > LayoutTests/fast/forms/output/output-labels.html:7 > +function collect(xs) What does "xs" stand for? The name "collect" is not so descriptive. > LayoutTests/fast/forms/output/output-labels.html:14 > +{ > + var result = ''; > + for (var i = 0; i < xs.length; i++) { > + result += xs[i].id; > + } > + return result; > +} Wrong indentation.
fast/forms/label/labelable-elements.html fails partly because of this issue in GTK.
Will this fix https://bugs.webkit.org/show_bug.cgi?id=80985?
(In reply to comment #4) > Will this fix https://bugs.webkit.org/show_bug.cgi?id=80985? No, this won't. Bug 80985 is caused by ENABLE flag differences and JSC/V8 difference.
(In reply to comment #5) > (In reply to comment #4) > > Will this fix https://bugs.webkit.org/show_bug.cgi?id=80985? > > No, this won't. Bug 80985 is caused by ENABLE flag differences and JSC/V8 difference. Correction: JSC/V8 difference will be solved by this bug. ENABLE flag difference won't be solved.
Created attachment 131772 [details] Patch 2
Comment on attachment 131772 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=131772&action=review The code change is ok. > LayoutTests/platform/chromium/fast/forms/label/labelable-elements-expected.txt:48 > Labelable: output [object HTMLOutputElement] > -FAIL element.labels.length should be 1. Threw exception TypeError: Cannot read property 'length' of null > +PASS element.labels.length is 1 You need to update the following files too: LayoutTests/platform/mac/fast/forms/label/labelable-elements-expected.txt LayoutTests/fast/forms/label/labelable-elements-expected.txt
Created attachment 131783 [details] Patch 3
Comment on attachment 131783 [details] Patch 3 ok
Comment on attachment 131783 [details] Patch 3 Clearing flags on attachment: 131783 Committed r110664: <http://trac.webkit.org/changeset/110664>
All reviewed patches have been landed. Closing bug.