Bug 80464 - [chromium] Support printing WebGL content in threaded compositor
Summary: [chromium] Support printing WebGL content in threaded compositor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on: 80459
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-06 17:40 PST by James Robinson
Modified: 2012-03-07 15:56 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.65 KB, patch)
2012-03-06 17:42 PST, James Robinson 		no flags Details | Formatted Diff | Diff
Patch (4.72 KB, patch)
2012-03-07 13:25 PST, James Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-03-06 17:40:41 PST 
[chromium] Support printing WebGL content in threaded compositor
Comment 1 James Robinson 2012-03-06 17:42:24 PST 
Created attachment 130496 [details]
Patch
Comment 2 James Robinson 2012-03-07 13:25:10 PST 
Created attachment 130681 [details]
Patch
Comment 3 James Robinson 2012-03-07 13:25:50 PST 
Updated to ToT.  I've confirmed manually that printing and lost context recovery work for WebGL content in threaded mode.
Comment 4 Kenneth Russell 2012-03-07 14:02:09 PST 
Comment on attachment 130681 [details]
Patch

Fantastic. Thanks for taking care of this. r=me
Comment 5 Adrienne Walker 2012-03-07 14:19:22 PST 
Comment on attachment 130681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130681&action=review

> Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:111
> +    if (m_textureUpdated || !m_drawingBuffer || !drawsContent())

Shouldn't this be context()? Can't m_drawingBuffer->graphicsContext3D() be potentially null?
Comment 6 James Robinson 2012-03-07 14:21:11 PST 
Looking at WebGLLayerChromium::setDrawingBuffer() it looks like a non-NULL DrawingBuffer with a NULL DrawingBuffer::graphicsContext3D() is not a valid state for this code.
Comment 7 WebKit Review Bot 2012-03-07 15:55:55 PST 
Comment on attachment 130681 [details]
Patch

Clearing flags on attachment: 130681

Committed r110118: <http://trac.webkit.org/changeset/110118>
Comment 8 WebKit Review Bot 2012-03-07 15:56:02 PST 
All reviewed patches have been landed.  Closing bug.