Bug 80457 - Further harden 64-bit JIT
Summary: Further harden 64-bit JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 17:13 PST by Oliver Hunt
Modified: 2012-03-07 17:07 PST (History)
4 users (show)

See Also:


Attachments
Patch (51.55 KB, patch)
2012-03-06 17:17 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (51.91 KB, patch)
2012-03-06 17:43 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (51.86 KB, patch)
2012-03-07 16:54 PST, Oliver Hunt
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-03-06 17:13:42 PST
Further harden 64-bit JIT
Comment 1 Oliver Hunt 2012-03-06 17:17:35 PST
Created attachment 130483 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-06 17:23:57 PST
Attachment 130483 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/X86Assembler.h:645:  xorq_rm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/X86Assembler.h:650:  rorq_i8r is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-03-06 17:25:58 PST
Comment on attachment 130483 [details]
Patch

Attachment 130483 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11838628
Comment 4 Oliver Hunt 2012-03-06 17:43:11 PST
Created attachment 130497 [details]
Patch
Comment 5 WebKit Review Bot 2012-03-06 17:46:23 PST
Attachment 130497 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/X86Assembler.h:645:  xorq_rm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/X86Assembler.h:650:  rorq_i8r is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Early Warning System Bot 2012-03-06 17:56:53 PST
Comment on attachment 130497 [details]
Patch

Attachment 130497 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11836646
Comment 7 Early Warning System Bot 2012-03-07 15:37:09 PST
Comment on attachment 130497 [details]
Patch

Attachment 130497 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/11843002
Comment 8 Oliver Hunt 2012-03-07 16:54:01 PST
Created attachment 130727 [details]
Patch
Comment 9 WebKit Review Bot 2012-03-07 16:57:41 PST
Attachment 130727 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/X86Assembler.h:645:  xorq_rm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/X86Assembler.h:650:  rorq_i8r is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Filip Pizlo 2012-03-07 16:58:39 PST
Comment on attachment 130727 [details]
Patch

r=me!
Comment 11 Oliver Hunt 2012-03-07 17:07:50 PST
Committed r110122: <http://trac.webkit.org/changeset/110122>