Bug 80448 – [BlackBerry] WebKit rendering problem when show/hide VKB

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Jacky Jiang]

Absolute positioned element with percentage top was rendered as invalid content when show/hide virtual keyboard. 
PR #141727.

[Jacky Jiang]

Created attachment 130630 [details]
Patch

[Antonio Gomes]

Comment on attachment 130630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130630&action=review

> Source/WebKit/blackberry/ChangeLog:14
> +
> +        When setting viewport size, layout happens inside
> +        WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is
> +        outside of the code path of "needsLayout" so that the contents are
> +        not rendered into the backing store. This is a regression of r108718,
> +        switch back to do the layout inside the public API
> +        WebPage::setDefaultLayoutSize().

it worries me very my that WebPage::xxx does more than WebPagePrivate:xxx methods :/

please lets fix this in a follow up.

[Jacky Jiang]

(In reply to comment #2)
> (From update of attachment 130630 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130630&action=review
> 
> > Source/WebKit/blackberry/ChangeLog:14
> > +
> > +        When setting viewport size, layout happens inside
> > +        WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is
> > +        outside of the code path of "needsLayout" so that the contents are
> > +        not rendered into the backing store. This is a regression of r108718,
> > +        switch back to do the layout inside the public API
> > +        WebPage::setDefaultLayoutSize().
> 
> it worries me very my that WebPage::xxx does more than WebPagePrivate:xxx methods :/
> 
> please lets fix this in a follow up.

OK, I will try it.

[WebKit Review Bot]

Comment on attachment 130630 [details]
Patch

Clearing flags on attachment: 130630

Committed r110076: <http://trac.webkit.org/changeset/110076>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.