Bug 80440 - filter-build-webkit needs more filters
Summary: filter-build-webkit needs more filters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 13:16 PST by Dean Jackson
Modified: 2012-03-06 16:33 PST (History)
1 user (show)

See Also:


Attachments
Patch (3.55 KB, patch)
2012-03-06 15:59 PST, Dean Jackson
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2012-03-06 13:16:19 PST
A few new build steps are passing through fbwk as errors.
Comment 1 Dean Jackson 2012-03-06 15:59:53 PST
Created attachment 130459 [details]
Patch
Comment 2 Joseph Pecoraro 2012-03-06 16:04:34 PST
Comment on attachment 130459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130459&action=review

> Tools/Scripts/filter-build-webkit:154
> +    } elsif ($line =~ /^(PhaseScriptExecution|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|ProcessProductPackaging|CodeSign|SymLink|Updating|CompileXIB|StripNIB) ("[^"]+"|\S+)/) {

I often see these too. Could you add these? "CopyPlistFile" and "GenerateDSYMFile"
Comment 3 Dean Jackson 2012-03-06 16:33:44 PST
http://trac.webkit.org/changeset/109975