Bug 8044 - WebKit Visual Studio 2005 project shouldn't use the SolutionDir
Summary: WebKit Visual Studio 2005 project shouldn't use the SolutionDir
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: PC Windows Server 2003
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2006-03-28 16:53 PST by Justin Haygood
Modified: 2006-04-26 12:05 PDT (History)
1 user (show)

See Also:

Makes projects use project directory (31.41 KB, patch)
2006-03-28 17:00 PST, Justin Haygood
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Haygood 2006-03-28 16:53:21 PST
The paths should be relative to the projectdir.. so that the projects can be added to other solutions without breaking anything
Comment 1 Justin Haygood 2006-03-28 17:00:49 PST
Created attachment 7365 [details]
Makes projects use project directory
Comment 2 Justin Haygood 2006-03-28 17:04:53 PST
From #webkit:

[20:02] <boki> just curious: what's the benefit of that?
[20:03] <jhaygood> I have one big uber solution that has all of the webkit stuff in it
[20:03] <jhaygood> and thus the solutiondir is dift
[20:03] <jhaygood> the big solution makes it so that modifying webcore for instance makes spinneret realize it should relink
[20:03] <jhaygood> and so I don't need multiple VS2005 instances open
[20:04] <boki> might be worth to mention that in the bug :)
Comment 3 Darin Adler 2006-03-29 03:31:57 PST
Comment on attachment 7365 [details]
Makes projects use project directory

Seems fine. Being relative to the project at all is probably wrong for the long term, but this makes us less dependent on the solution structure, which is nice.

Please don't use tabs in your ChangeLog files though. We can't commit them with tabs and it just makes extra work for whoever lands the patch.
Comment 4 Eric Seidel (no email) 2006-03-30 22:20:39 PST
This is a great fix.  However it woudl be even better if it were pasted as a perl script as I'm not sure this still will apply cleanly.
Comment 5 Justin Haygood 2006-03-31 07:51:15 PST
I'm not good enough with Perl to write a script to do that...

But, if someone else wants to:

Comment 6 Geoffrey Garen 2006-04-26 12:05:36 PDT
+2006-04-26  Geoffrey Garen  <ggaren@apple.com>
+        Reviewed by Darin.
+        Committing the project file change jhaygood suggesed in
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=8044
+        WebKit Visual Studio 2005 project shouldn't use the SolutionDir
+        Instead of his patch, I used the following commands:
+        sed -e 's/$(SolutionDir)/$(ProjectDir)\\../g' Image\ Viewer/Image\
+        Viewer.vcproj > Image\ Viewer/Image\ Viewer.vcproj_ && mv Image\
+        Viewer/Image\ Viewer.vcproj_ Image\ Viewer/Image\ Viewer.vcproj
+        sed -e 's/$(SolutionDir)/$(ProjectDir)\\../g'
+        WebCore/WebCore.vcproj > WebCore/WebCore.vcproj_ && mv
+        WebCore/WebCore.vcproj_ WebCore/WebCore.vcproj
+        * Viewer.vcproj:
+        * WebCore.vcproj/WebCore/WebCore.vcproj: