Bug 80433 – [Mac] Add optional support GeolocationClient::setEnableHighAccuracy()

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit Misc.

[Benjamin Poulain]

Wire the Geolocation client so that the WebGeolocationProvider can provides setEnableHighAccuracy() if needed.

[Benjamin Poulain]

Created attachment 130412 [details]
Patch

[Brent Fulgham]

Why has this been sitting here for eight months?  Looks reasonable, but are there any tests that can be run to confirm things work as expected?

[Brent Fulgham]

Comment on attachment 130412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130412&action=review

> Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm:71
> +    id<WebGeolocationProvider> geolocationProvider = [m_webView _geolocationProvider];

My only concern was whether this would violate any private API etiquette, but I see that other implementations in this same file already access this "private" method.

> Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm:72
> +    if ([geolocationProvider respondsToSelector:@selector(operationShouldProceed)])

Why are we checking for the operationShouldProceed here? Wouldn't we want to check for "setEnableHighAccuracy:"?

[Benjamin Poulain]

Comment on attachment 130412 [details]
Patch

Oh gosh, I totally forgot about that, sorry.

I remove it from the queue. It is not needed for now.

[Benjamin Poulain]

> > Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm:72
> > +    if ([geolocationProvider respondsToSelector:@selector(operationShouldProceed)])
> 
> Why are we checking for the operationShouldProceed here? Wouldn't we want to check for "setEnableHighAccuracy:"?

That is correct. An unfortunate copy-paste.

[Benjamin Poulain]

Irrelevant now.