Bug 80433 - [Mac] Add optional support GeolocationClient::setEnableHighAccuracy()
: [Mac] Add optional support GeolocationClient::setEnableHighAccuracy()
Status: RESOLVED INVALID
Product: WebKit
Classification: Unclassified
Component: WebKit Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Benjamin Poulain
: EasyFix
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-06 11:06 PST by Benjamin Poulain
Modified: 2014-02-03 13:51 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.06 KB, patch)
2012-03-06 11:08 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-03-06 11:06:54 PST
Wire the Geolocation client so that the WebGeolocationProvider can provides setEnableHighAccuracy() if needed.
Comment 1 Benjamin Poulain 2012-03-06 11:08:52 PST
Created attachment 130412 [details]
Patch
Comment 2 Brent Fulgham 2012-11-19 22:18:12 PST
Why has this been sitting here for eight months?  Looks reasonable, but are there any tests that can be run to confirm things work as expected?
Comment 3 Brent Fulgham 2012-11-19 22:37:08 PST
Comment on attachment 130412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130412&action=review

> Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm:71
> +    id<WebGeolocationProvider> geolocationProvider = [m_webView _geolocationProvider];

My only concern was whether this would violate any private API etiquette, but I see that other implementations in this same file already access this "private" method.

> Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm:72
> +    if ([geolocationProvider respondsToSelector:@selector(operationShouldProceed)])

Why are we checking for the operationShouldProceed here? Wouldn't we want to check for "setEnableHighAccuracy:"?
Comment 4 Benjamin Poulain 2012-11-19 23:43:57 PST
Comment on attachment 130412 [details]
Patch

Oh gosh, I totally forgot about that, sorry.

I remove it from the queue. It is not needed for now.
Comment 5 Benjamin Poulain 2012-11-19 23:45:09 PST
> > Source/WebKit/mac/WebCoreSupport/WebGeolocationClient.mm:72
> > +    if ([geolocationProvider respondsToSelector:@selector(operationShouldProceed)])
> 
> Why are we checking for the operationShouldProceed here? Wouldn't we want to check for "setEnableHighAccuracy:"?

That is correct. An unfortunate copy-paste.
Comment 6 Benjamin Poulain 2014-02-03 13:51:38 PST
Irrelevant now.