Bug 80430 – [BlackBerry] Set correct ResourceRequest target type.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Lyon Chen]

Right now ResourceRequests loaded by appCache are not set with correct target type. Also Worker related ResourceRequest are not correctly set for BlackBerry platform.

[Lyon Chen]

Created attachment 130406 [details]
Patch for 80430

Patch for 80430.

[Rob Buis]

Comment on attachment 130406 [details]
Patch for 80430

View in context: https://bugs.webkit.org/attachment.cgi?id=130406&action=review

The HashMap needs to be static for sure.

> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:92
> +    MimeTypeResourceRequestTypeMap* map = 0;

You need to make it static, otherwise you keep allocating it each time the function is called.

> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:114
> +            // map->add(String(""), ResourceRequest::TargetIsMedia);

Maybe better not include the commented three lines.

> Source/WebKit/blackberry/ChangeLog:8
> +        Removed unused code in dispatchWillSendRequest(), they are too late!

Can you explain what and why it is too late?

[Lyon Chen]

(In reply to comment #2)
> The HashMap needs to be static for sure.
> 
> You need to make it static, otherwise you keep allocating it each time the function is called.

Yes, this is an error, will fix.

> 
> Maybe better not include the commented three lines.
> 

Will remove them.

> Can you explain what and why it is too late?

In FrameLoaderClientBlackBerry::dispatchWillSendRequest() request.initializePlatformRequest() is called before the target type setting codes. And the target type is only referred to by us in initializePlatformRequest(), so it doesn't make sense to change the target type after it is used already.

[Lyon Chen]

Created attachment 130512 [details]
Updated patch based on rwlbuis's comments.

[Rob Buis]

Comment on attachment 130512 [details]
Updated patch based on rwlbuis's comments.

LGTM.

[WebKit Review Bot]

Comment on attachment 130512 [details]
Updated patch based on rwlbuis's comments.

Clearing flags on attachment: 130512

Committed r110023: <http://trac.webkit.org/changeset/110023>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.