Bug 80418 - Enable universal newlines in chromium android layout test runner
Summary: Enable universal newlines in chromium android layout test runner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sami Kyostila
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 07:21 PST by Sami Kyostila
Modified: 2012-03-06 11:08 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2012-03-06 07:27 PST, Sami Kyostila 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Kyostila 2012-03-06 07:21:32 PST 
Enable universal newlines in chromium android layout test runner
Comment 1 Sami Kyostila 2012-03-06 07:27:48 PST 
Created attachment 130379 [details]
Patch
Comment 2 Adam Barth 2012-03-06 08:49:33 PST 
Comment on attachment 130379 [details]
Patch

Thanks.
Comment 3 WebKit Review Bot 2012-03-06 09:52:40 PST 
Comment on attachment 130379 [details]
Patch

Rejecting attachment 130379 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
on 560 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium
Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 106.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2378.

Full output: http://queues.webkit.org/results/11839442
Comment 4 Sami Kyostila 2012-03-06 10:19:43 PST 
Comment on attachment 130379 [details]
Patch

That cq log looks pretty bizarre -- some transient failure perhaps? Let's have another go?
Comment 5 Adam Barth 2012-03-06 10:27:15 PST 
Comment on attachment 130379 [details]
Patch

Yeah, looks like it had trouble talking to one of the svn servers.
Comment 6 WebKit Review Bot 2012-03-06 11:08:41 PST 
Comment on attachment 130379 [details]
Patch

Clearing flags on attachment: 130379

Committed r109937: <http://trac.webkit.org/changeset/109937>
Comment 7 WebKit Review Bot 2012-03-06 11:08:46 PST 
All reviewed patches have been landed.  Closing bug.