Bug 80412 - Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
Summary: Web Inspector: extract source mapping logic from DebuggerPresentationModel to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 05:50 PST by Pavel Podivilov
Modified: 2012-03-07 02:55 PST (History)
10 users (show)

See Also:


Attachments
Patch (22.12 KB, patch)
2012-03-06 05:53 PST, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (23.79 KB, patch)
2012-03-07 02:08 PST, Pavel Podivilov
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-03-06 05:50:42 PST
Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
Comment 1 Pavel Podivilov 2012-03-06 05:53:02 PST
Created attachment 130365 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-06 08:03:23 PST
Comment on attachment 130365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130365&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-33
> - * @extends {WebInspector.ScriptMapping}

Let's keep ScriptMapping interface implemented by DebuggerPresentationModel to be used by external clients (uiLocationToRawLocation(), rawLocationToUILocation() etc.). Beside that we can have a MutableScriptMapping interface with addScript() and reset() methods to be implemented by MainScriptMapping and other helper script mappings inside MainScriptMapping.
Comment 3 Pavel Podivilov 2012-03-07 02:08:14 PST
Created attachment 130574 [details]
Patch
Comment 4 Pavel Podivilov 2012-03-07 02:55:26 PST
Committed r110043: <http://trac.webkit.org/changeset/110043>