Bug 80410 - Speech JavaScript API: add SpeechRecognitionError
Summary: Speech JavaScript API: add SpeechRecognitionError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks: 80260 80417 80424
  Show dependency treegraph
 
Reported: 2012-03-06 05:39 PST by Hans Wennborg
Modified: 2012-03-06 11:23 PST (History)
5 users (show)

See Also:


Attachments
Patch (15.47 KB, patch)
2012-03-06 06:01 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (15.50 KB, patch)
2012-03-06 06:15 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (16.65 KB, patch)
2012-03-06 07:34 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2012-03-06 05:39:48 PST
Speech JavaScript API: add SpeechRecognitionError
Comment 1 Hans Wennborg 2012-03-06 06:01:36 PST
Created attachment 130366 [details]
Patch
Comment 2 Hans Wennborg 2012-03-06 06:15:39 PST
Created attachment 130369 [details]
Patch

Rebase
Comment 3 Satish Sampath 2012-03-06 06:50:31 PST
Comment on attachment 130369 [details]
Patch

> Source/WebCore/Modules/speech/SpeechRecognitionError.h: 52
> Kind code() { return m_kind; }

Should the type be named as 'Code' and the variable m_code so that this getter actually gets the parameter with that name?

> LayoutTests/fast/speech/scripted/speechrecognitionerror-basics.html: 12
> shouldBeTrue("'webkitSpeechRecognitionError' in self");

using 'self' works here but perhaps it would be clearer to use 'window' instead?
Comment 4 Hans Wennborg 2012-03-06 07:34:06 PST
(In reply to comment #3)
> (From update of attachment 130369 [details])
> > Source/WebCore/Modules/speech/SpeechRecognitionError.h: 52
> > Kind code() { return m_kind; }
> 
> Should the type be named as 'Code' and the variable m_code so that this getter actually gets the parameter with that name?

Done.

> 
> > LayoutTests/fast/speech/scripted/speechrecognitionerror-basics.html: 12
> > shouldBeTrue("'webkitSpeechRecognitionError' in self");
> 
> using 'self' works here but perhaps it would be clearer to use 'window' instead?

Done.
Comment 5 Hans Wennborg 2012-03-06 07:34:31 PST
Created attachment 130381 [details]
Patch
Comment 6 Satish Sampath 2012-03-06 07:36:31 PST
looks good to me
Comment 7 Adam Barth 2012-03-06 10:22:24 PST
Comment on attachment 130381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130381&action=review

Looks great.  Thanks!

> Source/WebCore/ChangeLog:8
> +        Add SpeechRecognitionError.

Can you add a link to the spec?  That will help folks who look at this change later.
Comment 8 Adam Barth 2012-03-06 10:23:03 PST
> Can you add a link to the spec?  That will help folks who look at this change later.

Please feel free to ignore this comment on this change, but for the upcoming changes, it would be nice to link to the spec.
Comment 9 WebKit Review Bot 2012-03-06 11:23:33 PST
Comment on attachment 130381 [details]
Patch

Clearing flags on attachment: 130381

Committed r109938: <http://trac.webkit.org/changeset/109938>
Comment 10 WebKit Review Bot 2012-03-06 11:23:38 PST
All reviewed patches have been landed.  Closing bug.