Bug 80405 - [Shadow DOM] Extends path notation used in test utility function so that we can specify arbitrary ShadowRoot in Shadow Tree.
Summary: [Shadow DOM] Extends path notation used in test utility function so that we c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 79197
  Show dependency tree / graph
 
Reported: 2012-03-06 04:37 PST by Hayato Ito
Modified: 2012-03-06 23:19 PST (History)
6 users (show)

See Also:

Attachments
support multiple shadowroots notation (13.35 KB, patch)
2012-03-06 04:42 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Patch for landing (13.45 KB, patch)
2012-03-06 17:53 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Patch for landing (13.43 KB, patch)
2012-03-06 18:26 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2012-03-06 04:37:11 PST 
Some layout tests (in fast/dom/shadow) use a 'getElementByIdInShadow(path)' utility function, which does not support getting an element in arbitrary ShadowRoot.
We can get an element only from the youngest ShadowRoot by the current path notation.

It'd be nice to get an element from arbitrary ShadowRoot in ShadowTree, extending path notation.
Comment 1 Hayato Ito 2012-03-06 04:42:12 PST 
Created attachment 130353 [details]
support multiple shadowroots notation
Comment 2 Dimitri Glazkov (Google) 2012-03-06 08:57:09 PST 
Comment on attachment 130353 [details]
support multiple shadowroots notation

View in context: https://bugs.webkit.org/attachment.cgi?id=130353&action=review

> LayoutTests/fast/dom/shadow/resources/shadow-dom.js:38
> +function getElementInShadowTree(path)

ShadowTreeStack maybe?
Comment 3 Hayato Ito 2012-03-06 17:38:05 PST 
Thank you for the review.

(In reply to comment #2)
> (From update of attachment 130353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130353&action=review
> 
> > LayoutTests/fast/dom/shadow/resources/shadow-dom.js:38
> > +function getElementInShadowTree(path)
> 
> ShadowTreeStack maybe?


Okay. Let me rename that. I'll land this patch after renaming.
Comment 4 Hayato Ito 2012-03-06 17:53:57 PST 
Created attachment 130501 [details]
Patch for landing
Comment 5 Hayato Ito 2012-03-06 18:05:17 PST 
Let me merge this patch with http://trac.webkit.org/changeset/109967.
Comment 6 Hayato Ito 2012-03-06 18:26:28 PST 
Created attachment 130510 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-03-06 23:19:24 PST 
Comment on attachment 130510 [details]
Patch for landing

Clearing flags on attachment: 130510

Committed r110022: <http://trac.webkit.org/changeset/110022>
Comment 8 WebKit Review Bot 2012-03-06 23:19:28 PST 
All reviewed patches have been landed.  Closing bug.