Bug 80395 - Web Inspector: remove reference to RawSourceCode from UISourceCode.
Summary: Web Inspector: remove reference to RawSourceCode from UISourceCode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 00:54 PST by Pavel Podivilov
Modified: 2012-03-06 04:12 PST (History)
10 users (show)

See Also:

Attachments
Patch (15.84 KB, patch)
2012-03-06 00:57 PST, Pavel Podivilov 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-03-06 00:54:21 PST 
Web Inspector: remove reference to RawSourceCode from UISourceCode.
Comment 1 Pavel Podivilov 2012-03-06 00:57:08 PST 
Created attachment 130325 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-06 02:01:03 PST 
Comment on attachment 130325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130325&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:217
> +        for (var i = 0; i < addedItems.length; ++i)

We should probably process removedItems first and then addedItems.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274
> +        var script = WebInspector.debuggerModel.scriptForSourceID(rawLocation.scriptId);

Do you need script at all? Looks like scriptId is enough.
Comment 3 Pavel Podivilov 2012-03-06 03:55:22 PST 
Comment on attachment 130325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130325&action=review

>> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:217
>> +        for (var i = 0; i < addedItems.length; ++i)
> 
> We should probably process removedItems first and then addedItems.

Done.

>> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274
>> +        var script = WebInspector.debuggerModel.scriptForSourceID(rawLocation.scriptId);
> 
> Do you need script at all? Looks like scriptId is enough.

I think it should actually be "WebInspector.resourceForURL(script.sourceURL)" below. So I better keep the script.
Comment 4 Pavel Podivilov 2012-03-06 04:12:12 PST 
Committed r109899: <http://trac.webkit.org/changeset/109899>