Bug 80385 - [Qt][WK2] New hybi tests crash
Summary: [Qt][WK2] New hybi tests crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Jocelyn Turcotte
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 79668 80103
  Show dependency treegraph
 
Reported: 2012-03-05 23:27 PST by Csaba Osztrogonác
Modified: 2012-05-14 07:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2012-05-14 06:58 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-03-05 23:27:30 PST
http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html and
http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html
introduced in http://trac.webkit.org/changeset/109840 but crash on Qt-WK2

crash log:
terminate called after throwing an instance of 'std::length_error'
  what():  basic_string::_S_create
Comment 1 Csaba Osztrogonác 2012-03-06 00:09:10 PST
I skipped them to paint the bot green - http://trac.webkit.org/changeset/109868
Comment 2 Jocelyn Turcotte 2012-05-14 06:39:31 PDT
Was this easily reproducible? The test passes fine for me.
Comment 3 Csaba Osztrogonác 2012-05-14 06:42:40 PDT
(In reply to comment #2)
> Was this easily reproducible? The test passes fine for me.

Unfortunately I don't remember, it is a 2 months old bug.
But if they pass, let's try to unskip them and watch the bots.
Comment 4 Csaba Osztrogonác 2012-05-14 06:58:30 PDT
I unskipped them - https://trac.webkit.org/changeset/116943, let's watch the bots.
Comment 5 Jocelyn Turcotte 2012-05-14 06:58:39 PDT
Created attachment 141721 [details]
Patch
Comment 6 Csaba Osztrogonác 2012-05-14 06:59:51 PDT
Comment on attachment 141721 [details]
Patch

Sorry. I didn't know you're preparing the patch.
Comment 7 Csaba Osztrogonác 2012-05-14 07:03:02 PDT
They pass on the bot now, thanks.