Bug 80379 - CSS3 calc: rewrite margin test to use getComputedStyle
Summary: CSS3 calc: rewrite margin test to use getComputedStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Lawther
URL:
Keywords:
Depends on:
Blocks: 16662
  Show dependency tree / graph
 
Reported: 2012-03-05 22:18 PST by Mike Lawther
Modified: 2012-03-06 01:06 PST (History)
2 users (show)

See Also:

Attachments
Patch (11.87 KB, patch)
2012-03-05 22:20 PST, Mike Lawther 		no flags Details | Formatted Diff | Diff
Patch (11.88 KB, patch)
2012-03-05 22:27 PST, Mike Lawther 		no flags Details | Formatted Diff | Diff
Patch for landing (10.67 KB, patch)
2012-03-05 22:45 PST, Mike Lawther 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2012-03-05 22:18:57 PST 
CSS3 calc: rewrite margin test to use pre/post js
Comment 1 Mike Lawther 2012-03-05 22:20:24 PST 
Created attachment 130292 [details]
Patch
Comment 2 Mike Lawther 2012-03-05 22:27:48 PST 
Created attachment 130293 [details]
Patch
Comment 3 Kent Tamura 2012-03-05 22:35:51 PST 
Comment on attachment 130293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130293&action=review

> LayoutTests/css3/calc/margin-expected.txt:2
> +PASS getComputedStyle(document.getElementById("simple-all"), null).marginLeft is "25px"
> +PASS getComputedStyle(document.getElementById("simple-all"), null).marginTop is "25px"

nit: The result looks too busy. We can simplify it by adding functions.  e.g.
 computedMarginLeft("simple-all")
 computedMarginTop("simple-all")
 ...
Comment 4 Mike Lawther 2012-03-05 22:44:27 PST 
> nit: The result looks too busy. We can simplify it by adding functions.  e.g.
>  computedMarginLeft("simple-all")
>  computedMarginTop("simple-all")

Good idea - done.
Comment 5 Mike Lawther 2012-03-05 22:45:05 PST 
Created attachment 130297 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-03-06 01:06:52 PST 
Comment on attachment 130297 [details]
Patch for landing

Clearing flags on attachment: 130297

Committed r109874: <http://trac.webkit.org/changeset/109874>
Comment 7 WebKit Review Bot 2012-03-06 01:06:56 PST 
All reviewed patches have been landed.  Closing bug.