Bug 80377 - [BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream
Summary: [BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h]...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 22:18 PST by Jonathan Dong
Modified: 2012-03-06 04:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2012-03-05 22:28 PST, Jonathan Dong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-03-05 22:18:51 PST 
As some of the function names changed in class MediaPlayerPrivate with the upstream of MediaPlayerPrivateBlackBerry.[cpp|h], we should update WebKit/blackberry/Api/WebPage.cpp which uses these functions accordingly.

renamed functions in MediaPlayerPrivate:
windowGet() -> getWindow()
windowPositionGet() -> getWindowPosition()
mmrContextNameGet() -> mmrContextName()
Comment 1 Jonathan Dong 2012-03-05 22:28:30 PST 
Created attachment 130294 [details]
Patch
Comment 2 Rob Buis 2012-03-06 04:41:39 PST 
Comment on attachment 130294 [details]
Patch

LGTM. But maybe window() instead of windowGet(), this would be more webkit style.
Comment 3 WebKit Review Bot 2012-03-06 04:59:53 PST 
Comment on attachment 130294 [details]
Patch

Clearing flags on attachment: 130294

Committed r109907: <http://trac.webkit.org/changeset/109907>
Comment 4 WebKit Review Bot 2012-03-06 04:59:58 PST 
All reviewed patches have been landed.  Closing bug.