RESOLVED FIXED 80375
Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLength(). 
https://bugs.webkit.org/show_bug.cgi?id=80375
Summary Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::...
Luke Macpherson
Reported 2012-03-05 21:04:55 PST
Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLength().
Attachments
Patch (10.26 KB, patch)
2012-03-05 21:17 PST, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-03-05 21:17:08 PST
Created attachment 130279 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-05 21:58:38 PST
Comment on attachment 130279 [details] Patch I like this, but we should just early return now, since we don't need to fal through to the return l. Do we know if this has a perf effect? (I kinda doubt it would).
Luke Macpherson
Comment 3 2012-03-06 14:09:00 PST
I agree, but didn't change this function too much because I expect it to disappear entirely in a follow-up patch.
WebKit Review Bot
Comment 4 2012-03-06 15:07:07 PST
Comment on attachment 130279 [details] Patch Clearing flags on attachment: 130279 Committed r109964: <http://trac.webkit.org/changeset/109964>
WebKit Review Bot
Comment 5 2012-03-06 15:07:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.